Add fetching specified googletest version#14
Open
Solpatium wants to merge 2 commits intostarkware-libs:masterfrom
Open
Add fetching specified googletest version#14Solpatium wants to merge 2 commits intostarkware-libs:masterfrom
Solpatium wants to merge 2 commits intostarkware-libs:masterfrom
Conversation
ilyalesokhin-starkware
requested changes
Aug 16, 2022
Collaborator
ilyalesokhin-starkware
left a comment
ilyalesokhin-starkware
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Solpatium)
CMakeLists.txt line 10 at r1 (raw file):
# Basic setup for gtest find_package(GTest REQUIRED) include_directories(${GTEST_INCLUDE_DIRS})
how come this is no longer nessiary?
Code quote:
include_directories(${GTEST_INCLUDE_DIRS})
Contributor
Author
|
Although it did work before (I've just tested it) I don't see in the docs about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #11.